Skip to content

Add branch coverage for logical OR conditions #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 22, 2020

Conversation

cgewecke
Copy link
Member

@cgewecke cgewecke commented Apr 20, 2020

#175

Detect and report untaken OR branches..

Screen Shot 2020-04-21 at 6 43 45 PM

TODO

  • Add unit test cases
  • Add truffle/buidler case
  • Support require/assert
  • Support while
  • Support return
  • Support if/else
  • Check html for highlighting correctness.
  • Gate behind experimental option flag
  • E2E
    • synthetix
    • aragon-court
    • bzx? (lots of ORs...)
  • Document

@cgewecke cgewecke force-pushed the logical-or-coverage branch from a29d712 to 9b169aa Compare April 22, 2020 02:00
@cgewecke cgewecke force-pushed the logical-or-coverage branch from 9b169aa to 4f07bd6 Compare April 22, 2020 03:33
@codecov-io
Copy link

codecov-io commented Apr 22, 2020

Codecov Report

Merging #499 into experimental-options will increase coverage by 0.04%.
The diff coverage is 98.55%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           experimental-options     #499      +/-   ##
========================================================
+ Coverage                 99.24%   99.28%   +0.04%     
========================================================
  Files                        20       20              
  Lines                       790      843      +53     
========================================================
+ Hits                        784      837      +53     
  Misses                        6        6              
Impacted Files Coverage Δ
lib/parse.js 96.73% <95.45%> (+0.68%) ⬆️
lib/coverage.js 100.00% <100.00%> (ø)
lib/injector.js 100.00% <100.00%> (ø)
lib/instrumenter.js 100.00% <100.00%> (ø)
lib/registrar.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a2e3a...4f07bd6. Read the comment docs.

@cgewecke cgewecke changed the base branch from master to experimental-options April 22, 2020 03:57
@cgewecke cgewecke marked this pull request as ready for review April 22, 2020 03:57
@cgewecke cgewecke merged commit 15ad590 into experimental-options Apr 22, 2020
@cgewecke cgewecke mentioned this pull request Apr 22, 2020
40 tasks
cgewecke added a commit that referenced this pull request Apr 30, 2020
* Add initial OR coverage test cases

* Add logicalOR coverage for "require" conditions

* Add logicalOR coverage for "while" conditions

* Add logicalOR coverage for "return" conditions

* Add logicalOR coverage for "if" conditions

* Add logicalOR branch highlighting for html report
cgewecke added a commit that referenced this pull request Jun 11, 2020
* Add initial OR coverage test cases

* Add logicalOR coverage for "require" conditions

* Add logicalOR coverage for "while" conditions

* Add logicalOR coverage for "return" conditions

* Add logicalOR coverage for "if" conditions

* Add logicalOR branch highlighting for html report
cgewecke added a commit that referenced this pull request Jun 17, 2020
* Add initial OR coverage test cases

* Add logicalOR coverage for "require" conditions

* Add logicalOR coverage for "while" conditions

* Add logicalOR coverage for "return" conditions

* Add logicalOR coverage for "if" conditions

* Add logicalOR branch highlighting for html report
cgewecke added a commit that referenced this pull request Dec 3, 2020
* Add initial OR coverage test cases

* Add logicalOR coverage for "require" conditions

* Add logicalOR coverage for "while" conditions

* Add logicalOR coverage for "return" conditions

* Add logicalOR coverage for "if" conditions

* Add logicalOR branch highlighting for html report
cgewecke added a commit that referenced this pull request Dec 16, 2020
* Add initial OR coverage test cases

* Add logicalOR coverage for "require" conditions

* Add logicalOR coverage for "while" conditions

* Add logicalOR coverage for "return" conditions

* Add logicalOR coverage for "if" conditions

* Add logicalOR branch highlighting for html report
cgewecke added a commit that referenced this pull request Apr 26, 2022
* Add initial OR coverage test cases

* Add logicalOR coverage for "require" conditions

* Add logicalOR coverage for "while" conditions

* Add logicalOR coverage for "return" conditions

* Add logicalOR coverage for "if" conditions

* Add logicalOR branch highlighting for html report
cgewecke added a commit that referenced this pull request Apr 26, 2022
* Add initial OR coverage test cases

* Add logicalOR coverage for "require" conditions

* Add logicalOR coverage for "while" conditions

* Add logicalOR coverage for "return" conditions

* Add logicalOR coverage for "if" conditions

* Add logicalOR branch highlighting for html report
@frangio frangio mentioned this pull request Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants